linux-kernel - Re: [PATCH v5] LoongArch: Fix CONFIG_CMDLINE_EXTEND and CONFIG_CMDLINE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2023 01:34:55 +0000
From:   ‎ donmor <donmor3000@...mail.com>
To:     "Markus.Elfring@....de" <Markus.Elfring@....de>,
        "chenhuacai@...nel.org" <chenhuacai@...nel.org>,
        "kernel@...0n.name" <kernel@...0n.name>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "jiaxun.yang@...goat.com" <jiaxun.yang@...goat.com>,
        "loongarch@...ts.linux.dev" <loongarch@...ts.linux.dev>,
        "chenhuacai@...ngson.cn" <chenhuacai@...ngson.cn>,
        "guoren@...nel.org" <guoren@...nel.org>,
        "lixuefeng@...ngson.cn" <lixuefeng@...ngson.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "loongson-kernel@...ts.loongnix.cn" 
        <loongson-kernel@...ts.loongnix.cn>
Subject: Re: [PATCH v5] LoongArch: Fix CONFIG_CMDLINE_EXTEND and
 CONFIG_CMDLINE_BOOTLOADER handling

在 2023-07-19星期三的 18:29 +0800，WANG Xuerui写道：
> On 2023/7/19 15:22, Huacai Chen wrote:
> > Hi, Markus,
> > 
> > On Wed, Jul 19, 2023 at 2:51 PM Markus Elfring <Markus.Elfring@....de> wrote:
> > > >                                                    …, so this patch add
> > > > some code to fix it.
> > > 
> > > Would you like to avoid a typo here?
> > > 
> > > Will any other imperative change description variant become more helpful?
> > Thank you for pointing this out, but since Zhihong is the original
> > author, I don't want to completely rewrite the commit message, so just
> > fix the typo...
> 
> AFAICT the commit message is totally uninformative even if "an 
> imperative change description" were used. It basically:
> 
> 1. repeated the patch title,
> 2. spent one sentence only for mentioning a function name without giving 
> any more information,
> 3. mentioned why some change was not necessary due to some other 
> existing code, but not explicitly calling that part out, then
> 4. finished with a sentence that boiled down to "we should do the 
> similar thing".
> 
> My take:
> 
>  > Subject: Fix CMDLINE_EXTEND and CMDLINE_BOOTLOADER on non-FDT systems
>  >
>  > On FDT systems these command line processing are already taken care of
>  > by early_init_dt_scan_chosen(). Add similar handling to the non-FDT
>  > code path to allow these config options to work for non-FDT boxes too.
> 
> Would this sound better?
> 
Xuerui's take is fine. Do I need to make a v6 patch?

donmor