[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5889e93b-5ee3-8d59-c2fb-bce7070a1ab2@intel.com>
Date: Thu, 20 Jul 2023 13:00:58 +0300
From: Adrian Hunter <adrian.hunter@...el.com>
To: Changbin Du <changbin.du@...wei.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Ian Rogers <irogers@...gle.com>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
Hui Wang <hw.huiwang@...wei.com>
Subject: Re: [PATCH v3 0/3] perf: add new option '--workload-attr' to set
workload sched_policy/priority/mask
On 18/07/23 06:33, Changbin Du wrote:
> This adds a new option '--workload-attr' to set the sched_policy/priority/mask
> of the workload to reduce system noise.
>
> $ sudo perf stat --workload-attr fifo,40,0-3:7 -- ls
Not really sold on the need for this, but maybe it could be
simpler.
What about just adding a hook for a command (e.g. script) to
run before exec'ing the workload e.g.
--configure-workload=blah.sh
results in perf doing system("blah.sh 12345") where 12345
is the workload PID.
Then maybe you could do:
--configure-workload="taskset -p 0x3"
>
> Please see patch 1/2 for more details.
>
> v3:
> - replace taskset with --workload-attr option in documents and tests.
> v2:
> - Use cpu list spec instead of cpu mask number.
> - Update documents.
>
> Changbin Du (3):
> perf cpumap: Add __perf_cpu_map__new and perf_cpu_map__2_cpuset
> perf: add new option '--workload-attr' to set workload
> sched_policy/priority/mask
> perf: replace taskset with --workload-attr option
>
> tools/lib/perf/cpumap.c | 45 ++++++-
> tools/lib/perf/include/perf/cpumap.h | 4 +
> tools/lib/perf/libperf.map | 2 +
> tools/perf/Documentation/intel-hybrid.txt | 2 +-
> tools/perf/Documentation/perf-record.txt | 7 ++
> tools/perf/Documentation/perf-stat.txt | 8 +-
> tools/perf/builtin-record.c | 26 ++++
> tools/perf/builtin-stat.c | 18 +++
> tools/perf/tests/cpumap.c | 23 ++++
> .../tests/shell/stat_bpf_counters_cgrp.sh | 2 +-
> tools/perf/tests/shell/test_arm_coresight.sh | 2 +-
> tools/perf/tests/shell/test_data_symbol.sh | 2 +-
> tools/perf/tests/shell/test_intel_pt.sh | 2 +-
> tools/perf/util/evlist.c | 117 ++++++++++++++++++
> tools/perf/util/evlist.h | 3 +
> tools/perf/util/target.h | 9 ++
> 16 files changed, 263 insertions(+), 9 deletions(-)
>
Powered by blists - more mailing lists