linux-kernel - Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add support for the RDP415 variant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15275174-4903-afd2-df7f-bc3d73a06d00@quicinc.com>
Date:   Thu, 20 Jul 2023 16:50:29 +0530
From:   Hariharan K <quic_harihk@...cinc.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        <agross@...nel.org>, <andersson@...nel.org>,
        <konrad.dybcio@...aro.org>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
CC:     <quic_srichara@...cinc.com>, <quic_sjaganat@...cinc.com>,
        <quic_kathirav@...cinc.com>, <quic_arajkuma@...cinc.com>,
        <quic_anusha@...cinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add support for the RDP415
 variant



On 7/20/2023 2:26 PM, Krzysztof Kozlowski wrote:
> On 20/07/2023 09:48, Hariharan K wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 415 based on IPQ5018 family of SoC. This patch
>> carries the support for Console UART and eMMC.
>>
>> Signed-off-by: Hariharan K <quic_harihk@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/Makefile           |  1 +
>>   arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts | 49 +++++++++++++++++++++
>>   2 files changed, 50 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 6334e552b7c1..53df7f24488a 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= apq8039-t2.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8094-sony-xperia-kitakami-karin_windy.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-db820c.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= apq8096-ifc6640.dtb
>> +dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp415.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5018-rdp432-c2.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp441.dtb
>>   dtb-$(CONFIG_ARCH_QCOM)	+= ipq5332-rdp442.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>> new file mode 100644
>> index 000000000000..5c4b43f76a48
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>> @@ -0,0 +1,49 @@
>> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
>> +/*
>> + * IPQ5018 MP03.3-C2 board device tree source
>> + * Copyright (c) 2023, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "ipq5018-rdp-common.dtsi"
> 
> I don't understand this. You just added in in the same moment in
> different patchset, so why creating this fake dependency?
> 
> It makes review difficult, applying even more.
> 
> Please organize your patches in some logical work.

Sure, got it. Will rework this series and post v2.

Best regards,
Hariharan K

> 
> Best regards,
> Krzysztof
>