[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2859212f7ed4c3014bc5ebe2a2097755190979bc.camel@mediatek.com>
Date: Thu, 20 Jul 2023 02:01:08 +0000
From: CK Hu (胡俊光) <ck.hu@...iatek.com>
To: "angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"wenst@...omium.org" <wenst@...omium.org>,
"kernel@...labora.com" <kernel@...labora.com>,
"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"nfraprado@...labora.com" <nfraprado@...labora.com>
Subject: Re: [PATCH v6 05/11] drm/mediatek: dp: Move AUX_P0 setting to
mtk_dp_initialize_aux_settings()
Hi, Angelo:
On Mon, 2023-07-17 at 16:14 +0200, AngeloGioacchino Del Regno wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply
> mode
> to function mtk_dp_initialize_aux_settings(), as this is effectively
> part of the DPTX AUX setup sequence.
Reviewed-by: CK Hu <ck.hu@...iatek.com>
>
> Signed-off-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@...labora.com>
> Tested-by: Chen-Yu Tsai <wenst@...omium.org>
> ---
> drivers/gpu/drm/mediatek/mtk_dp.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp.c
> b/drivers/gpu/drm/mediatek/mtk_dp.c
> index fc6cabf5370b..e8d3bf310608 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dp.c
> @@ -1009,6 +1009,11 @@ static void
> mtk_dp_initialize_aux_settings(struct mtk_dp *mtk_dp)
> mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_37C8,
> MTK_ATOP_EN_AUX_TX_P0,
> MTK_ATOP_EN_AUX_TX_P0);
> +
> + /* Set complete reply mode for AUX */
> + mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,
> + RX_REPLY_COMPLETE_MODE_AUX_TX_P0,
> + RX_REPLY_COMPLETE_MODE_AUX_TX_P0);
> }
>
> static void mtk_dp_initialize_digital_settings(struct mtk_dp
> *mtk_dp)
> @@ -1826,10 +1831,6 @@ static void mtk_dp_init_port(struct mtk_dp
> *mtk_dp)
> mtk_dp_initialize_settings(mtk_dp);
> mtk_dp_initialize_aux_settings(mtk_dp);
> mtk_dp_initialize_digital_settings(mtk_dp);
> -
> - mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,
> - RX_REPLY_COMPLETE_MODE_AUX_TX_P0,
> - RX_REPLY_COMPLETE_MODE_AUX_TX_P0);
> mtk_dp_initialize_hpd_detect_settings(mtk_dp);
>
> mtk_dp_digital_sw_reset(mtk_dp);
> --
> 2.40.1
Powered by blists - more mailing lists