linux-kernel - Re: [PATCH 1/3] arm64: dts: mediatek: mt6795: Add support for display blocks and DPI/DSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d892a76c-165b-dbeb-79aa-70f3ebd7f07c@collabora.com>
Date:   Thu, 20 Jul 2023 13:52:36 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Alexandre Mergnat <amergnat@...libre.com>, matthias.bgg@...il.com
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        conor+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, phone-devel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, kernel@...labora.com
Subject: Re: [PATCH 1/3] arm64: dts: mediatek: mt6795: Add support for display
 blocks and DPI/DSI

Il 20/07/23 13:35, Alexandre Mergnat ha scritto:
> 
> 
> On 20/07/2023 11:15, AngeloGioacchino Del Regno wrote:
>> Introduce all nodes for all of the display blocks in the MediaTek Helio
>> X10 MT6795 SoC, including the DSI PHY and DSI/DPI interfaces: those are
>> left disabled as usage is board specific.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt6795.dtsi | 252 +++++++++++++++++++++++
>>   1 file changed, 252 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt6795.dtsi 
>> b/arch/arm64/boot/dts/mediatek/mt6795.dtsi
>> index 597bce2fed72..d805d7a63024 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt6795.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt6795.dtsi
>> @@ -2,6 +2,9 @@
>>   /*
>>    * Copyright (c) 2015 MediaTek Inc.
>>    * Author: Mars.C <mars.cheng@...iatek.com>
>> + *
>> + * Copyright (C) 2023 Collabora Ltd.
>> + *                    AngeloGioacchino Del Regno 
>> <angelogioacchino.delregno@...labora.com>
> 
> Shouldn't be like this ?
> 
>   * Copyright (c) 2015 MediaTek Inc.
>   * Copyright (C) 2023 Collabora Ltd.
>   * Authors: Mars.C <mars.cheng@...iatek.com>
>   *          AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 
> 

I don't think that there's any rule about this?
Also I don't really mind the strings order, but if anyone really does, I can change
it....

>>    */
>>   #include <dt-bindings/interrupt-controller/irq.h>
...
>> @@ -708,6 +953,13 @@ smi_common: smi@...22000 {
>>               clock-names = "apb", "smi";
>>           };
>> +        od@...23000 {
>> +            compatible = "mediatek,mt6795-disp-od", "mediatek,mt8173-disp-od";
>> +            reg = <0 0x14023000 0 0x1000>;
>> +            clocks = <&mmsys CLK_MM_DISP_OD>;
>> +            mediatek,gce-client-reg = <&gce SUBSYS_1402XXXX 0x3000 0x1000>;
>> +        };
>> +
>>           larb2: larb@...01000 {
>>               compatible = "mediatek,mt6795-smi-larb";
>>               reg = <0 0x15001000 0 0x1000>;
> 
> Reviewed-by: Alexandre Mergnat <amergnat@...libre.com>
>