linux-kernel - Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2023 14:28:59 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Przemyslaw <przemekchwiala@...il.com>, hdegoede@...hat.com,
        m.szyprowski@...sung.com, sebastian.krzyszkowiak@...i.sm,
        kernel@...i.sm, sre@...nel.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     lukas.bulwahn@...il.com
Subject: Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_
 prefix in regular C code

On 20/07/2023 14:25, Przemyslaw wrote:
> From: przemoch <przemekchwiala@...il.com>

Please use the same name in commit author and SoB.

> 
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
> 
> Signed-off-by: Przemyslaw Chwiala <przemekchwiala@...il.com>

Code is okay, so please send v2 with fixed author.

Best regards,
Krzysztof