linux-kernel - Re: Driver for Nuvoton NCT6687D eSIO chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f5b8483-5a84-a41d-99b6-3c7a0c95b4e5@roeck-us.net>
Date:   Thu, 20 Jul 2023 06:25:43 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Thomas R <seatommyboy@...il.com>, jdelvare@...e.com,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Driver for Nuvoton NCT6687D eSIO chip

On 7/20/23 04:09, Thomas R wrote:
> To whom it may concern,
> 
> I am trying to submit a patch for driver Driver for Nuvoton NCT6687D eSIO chip under drivers/hwmon. This driver is confirmed to be working for motherboards series B550 and B650.
> 
> Credits for creating this driver should go to Frederic BOLTZ https://github.com/Fred78290/nct6687d
> 
> Attached is my patch

This is not the way to submit patches into the Linux kernel.

Anyway, this is pretty much just taking the existing nct6683 driver,
extending it with an additional ID for NCT6687 (0xd451), removing
customer ID checks, and claiming new authorship. No, this is not how
kernel development works. If those motherboards use an NCT6687 with
ID 0xd451, or if the boards use a new customer ID, submit patches updating
the existing driver. If there are other changes improving the existing
driver, submit patches for it. I am not going to accept a second driver
for the same chip.

Guenter