linux-kernel - Re: [PATCH v2] ext4: fix the time handling macros when ext4 is using small inodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230720144807.GC5764@mit.edu>
Date:   Thu, 20 Jul 2023 10:48:07 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Jeff Layton <jlayton@...nel.org>
Cc:     Andreas Dilger <adilger.kernel@...ger.ca>, Jan Kara <jack@...e.cz>,
        Christian Brauner <brauner@...nel.org>,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, Hugh Dickins <hughd@...gle.com>
Subject: Re: [PATCH v2] ext4: fix the time handling macros when ext4 is using
 small inodes

On Wed, Jul 19, 2023 at 06:32:19AM -0400, Jeff Layton wrote:
> If ext4 is using small on-disk inodes, then it may not be able to store
> fine grained timestamps. It also can't store the i_crtime at all in that
> case since that fully lives in the extended part of the inode.
> 
> 979492850abd got the EXT4_EINODE_{GET,SET}_XTIME macros wrong, and would
> still store the tv_sec field of the i_crtime into the raw_inode, even
> when they were small, corrupting adjacent memory.
> 
> This fixes those macros to skip setting anything in the raw_inode if the
> tv_sec field doesn't fit, and to properly return a {0,0} timestamp when
> the raw_inode doesn't support it.
> 
> Also, fix a bug in ctime handling during rename. It was updating the
> renamed inode's ctime twice rather than the old directory.
> 
> Cc: Jan Kara <jack@...e.cz>
> Fixes: 979492850abd ("ext4: convert to ctime accessor functions")
> Reported-by: Hugh Dickins <hughd@...gle.com>
> Tested-by: Hugh Dickins <hughd@...gle.com>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>

Acked-by: Theodore Ts'o <tytso@....edu>

I assume this is will be applied to the vfs.ctime branch, yes?

  	      	      	 	    	- Ted