linux-kernel - Re: [PATCH] drivers: gpio: Remove unnecessary spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=MfJbmJ7jkcZ-hQEpNKKtLJW7iU+AeZAWTHfnfn11J+aAg@mail.gmail.com>
Date:   Thu, 20 Jul 2023 16:52:28 +0200
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     hanyu001@...suo.com
Cc:     linus.walleij@...aro.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: gpio: Remove unnecessary spaces

On Thu, Jul 20, 2023 at 8:55 AM <hanyu001@...suo.com> wrote:
>
> Fix checkpatch warnings:
>
> ./drivers/gpio/gpio-pca953x.c:1352: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1353: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1354: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1359: ERROR: space prohibited after that
> open parenthesis '('
> ./drivers/gpio/gpio-pca953x.c:1360: ERROR: space prohibited after that
> open parenthesis '('
>
> Signed-off-by: Yu Han <hanyu001@...suo.com>
> ---
>   drivers/gpio/gpio-pca953x.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c
> index a806a3c..7f4f7ee 100644
> --- a/drivers/gpio/gpio-pca953x.c
> +++ b/drivers/gpio/gpio-pca953x.c
> @@ -1349,15 +1349,15 @@ static int pca953x_resume(struct device *dev)
>       { .compatible = "maxim,max7315", .data = OF_953X( 8, PCA_INT), },
>       { .compatible = "maxim,max7318", .data = OF_953X(16, PCA_INT), },
>
> -    { .compatible = "ti,pca6107", .data = OF_953X( 8, PCA_INT), },
> -    { .compatible = "ti,pca9536", .data = OF_953X( 4, 0), },
> -    { .compatible = "ti,tca6408", .data = OF_953X( 8, PCA_INT), },
> +    { .compatible = "ti,pca6107", .data = OF_953X(8, PCA_INT), },
> +    { .compatible = "ti,pca9536", .data = OF_953X(4, 0), },
> +    { .compatible = "ti,tca6408", .data = OF_953X(8, PCA_INT), },
>       { .compatible = "ti,tca6416", .data = OF_953X(16, PCA_INT), },
>       { .compatible = "ti,tca6424", .data = OF_953X(24, PCA_INT), },
>       { .compatible = "ti,tca9539", .data = OF_953X(16, PCA_INT), },
>
> -    { .compatible = "onnn,cat9554", .data = OF_953X( 8, PCA_INT), },
> -    { .compatible = "onnn,pca9654", .data = OF_953X( 8, PCA_INT), },
> +    { .compatible = "onnn,cat9554", .data = OF_953X(8, PCA_INT), },
> +    { .compatible = "onnn,pca9654", .data = OF_953X(8, PCA_INT), },
>       { .compatible = "onnn,pca9655", .data = OF_953X(16, PCA_INT), },
>
>       { .compatible = "exar,xra1202", .data = OF_953X( 8, 0), },

This doesn't apply to my for-next tree. And the commit message should
be: "gpio: pca953x: ..."

Bart