linux-kernel - Re: [PATCH] ARM: zynq: Explicitly include correct DT includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c93becf7-c3e8-090b-1f59-d9c1f68d75af@amd.com>
Date:   Thu, 20 Jul 2023 17:08:18 +0200
From:   Michal Simek <michal.simek@....com>
To:     Rob Herring <robh@...nel.org>, Russell King <linux@...linux.org.uk>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: zynq: Explicitly include correct DT includes



On 7/18/23 00:53, Rob Herring wrote:
> The DT of_device.h and of_platform.h date back to the separate
> of_platform_bus_type before it was merged into the regular platform bus.
> As part of that merge prepping Arm DT support 13 years ago, they
> "temporarily" include each other. They also include platform_device.h
> and of.h. As a result, there's a pretty much random mix of those include
> files used throughout the tree. In order to detangle these headers and
> replace the implicit includes with struct declarations, users need to
> explicitly include the correct includes.
> 
> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
>   arch/arm/mach-zynq/pm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-zynq/pm.c b/arch/arm/mach-zynq/pm.c
> index 8ba450ab559c..61ad965ef3ac 100644
> --- a/arch/arm/mach-zynq/pm.c
> +++ b/arch/arm/mach-zynq/pm.c
> @@ -8,8 +8,8 @@
>    */
>   
>   #include <linux/io.h>
> +#include <linux/of.h>
>   #include <linux/of_address.h>
> -#include <linux/of_device.h>
>   #include "common.h"
>   
>   /* register offsets */

Applied.
M