linux-kernel - Re: [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for HiSilicon H60PA and PAv3 PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLqgtRcgGqmHUXFM@sashalap>
Date:   Fri, 21 Jul 2023 11:13:57 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Junhao He <hejunhao3@...wei.com>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Yicong Yang <yangyicong@...ilicon.com>,
        Will Deacon <will@...nel.org>, zhangshaokun@...ilicon.com,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH AUTOSEL 6.4 11/12] drivers/perf: hisi: Add support for
 HiSilicon H60PA and PAv3 PMU driver

On Mon, Jul 03, 2023 at 11:14:37AM +0100, Mark Rutland wrote:
>On Sun, Jul 02, 2023 at 03:50:56PM -0400, Sasha Levin wrote:
>> From: Junhao He <hejunhao3@...wei.com>
>>
>> [ Upstream commit 1a51688474c0d395b864e98236335fba712e29bf ]
>>
>> Compared to the original PA device, H60PA offers higher bandwidth.
>> The H60PA is a new device and we use HID to differentiate them.
>>
>> The events supported by PAv3 and PAv2 are different. The PAv3 PMU
>> removed some events which are supported by PAv2 PMU. The older PA
>> PMU driver will probe v3 as v2. Therefore PA events displayed by
>> "perf list" cannot work properly. We add the HISI0275 HID for PAv3
>> PMU to distinguish different.
>>
>> For each H60PA PMU, except for the overflow interrupt register, other
>> functions of the H60PA PMU are the same as the original PA PMU module.
>> It has 8-programable counters and each counter is free-running.
>> Interrupt is supported to handle counter (64-bits) overflow.
>>
>> Signed-off-by: Junhao He <hejunhao3@...wei.com>
>> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
>> Reviewed-by: Yicong Yang <yangyicong@...ilicon.com>
>> Acked-by: Mark Rutland <mark.rutland@....com>
>> Link: https://lore.kernel.org/r/20230615125926.29832-2-hejunhao3@huawei.com
>> Signed-off-by: Will Deacon <will@...nel.org>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>> ---
>>  drivers/perf/hisilicon/hisi_uncore_pa_pmu.c | 127 +++++++++++++++++---
>>  drivers/perf/hisilicon/hisi_uncore_pmu.h    |   8 ++
>>  2 files changed, 120 insertions(+), 15 deletions(-)
>
>Why is this being backported to stable?
>
>This patch adds supoprt for new HW, and is clearly not a fix, so it's not clear
>to me why it has been selected.

I'll drop it, thanks.

-- 
Thanks,
Sasha