linux-kernel - RE: [PATCH v2 2/2] iommu/vt-d: Remove rmrr check in domain attaching device path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB52766C4CCF02DC8076D815218C3FA@BN9PR11MB5276.namprd11.prod.outlook.com>
Date:   Fri, 21 Jul 2023 03:11:14 +0000
From:   "Tian, Kevin" <kevin.tian@...el.com>
To:     Lu Baolu <baolu.lu@...ux.intel.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "Joerg Roedel" <joro@...tes.org>, Will Deacon <will@...nel.org>,
        Robin Murphy <robin.murphy@....com>,
        Alex Williamson <alex.williamson@...hat.com>,
        "Nicolin Chen" <nicolinc@...dia.com>
CC:     "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
        "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Jason Gunthorpe <jgg@...dia.com>
Subject: RE: [PATCH v2 2/2] iommu/vt-d: Remove rmrr check in domain attaching
 device path

> From: Lu Baolu <baolu.lu@...ux.intel.com>
> Sent: Thursday, July 13, 2023 12:33 PM
> 
> The core code now prevents devices with RMRR regions from being assigned
> to user space. There is no need to check for this condition in individual
> drivers. Remove it to avoid duplicate code.
> 
> Signed-off-by: Lu Baolu <baolu.lu@...ux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Reviewed-by: Kevin Tian <kevin.tian@...el.com>

A side note.

device_rmrr_is_relaxable() marks USB/GPU as relaxable. I wonder whether
this policy is specific to Intel platform or generally applied. If the latter
probably that could be moved to iommu core too.