[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <871qh1l14m.fsf@doe.com>
Date: Fri, 21 Jul 2023 21:15:13 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Kemeng Shi <shikemeng@...weicloud.com>, tytso@....edu,
adilger.kernel@...ger.ca, ojaswin@...ux.ibm.com,
linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: shikemeng@...weicloud.com
Subject: Re: [PATCH 07/10] ext4: remove unused ext4_{set}/{clear}_bit_atomic
Kemeng Shi <shikemeng@...weicloud.com> writes:
> Remove ext4_set_bit_atomic and ext4_clear_bit_atomic which are defined but not
> used.
>
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
> fs/ext4/ext4.h | 2 --
> 1 file changed, 2 deletions(-)
>
Looks good to me, feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>
-ritesh
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index 0a2d55faa095..7166edb2e4a7 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -1252,10 +1252,8 @@ struct ext4_inode_info {
>
> #define ext4_test_and_set_bit __test_and_set_bit_le
> #define ext4_set_bit __set_bit_le
> -#define ext4_set_bit_atomic ext2_set_bit_atomic
> #define ext4_test_and_clear_bit __test_and_clear_bit_le
> #define ext4_clear_bit __clear_bit_le
> -#define ext4_clear_bit_atomic ext2_clear_bit_atomic
> #define ext4_test_bit test_bit_le
> #define ext4_find_next_zero_bit find_next_zero_bit_le
> #define ext4_find_next_bit find_next_bit_le
> --
> 2.30.0
Powered by blists - more mailing lists