[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230721155022.2339982-12-lukasz.luba@arm.com>
Date: Fri, 21 Jul 2023 16:50:21 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
rafael@...nel.org
Cc: lukasz.luba@....com, dietmar.eggemann@....com, rui.zhang@...el.com,
amit.kucheria@...durent.com, amit.kachhap@...il.com,
daniel.lezcano@...aro.org, viresh.kumar@...aro.org,
len.brown@...el.com, pavel@....cz, Pierre.Gondois@....com,
ionela.voinescu@....com, mhiramat@...nel.org
Subject: [PATCH v3 11/12] PM: EM: Use runtime modified EM for CPUs energy estimation in EAS
The new Energy Model (EM) supports runtime modification of the performance
state table to better model the power used by the SoC. Use this new
feature to improve energy estimation and therefore task placement in
Energy Aware Scheduler (EAS).
Signed-off-by: Lukasz Luba <lukasz.luba@....com>
---
include/linux/energy_model.h | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/include/linux/energy_model.h b/include/linux/energy_model.h
index fd4110166e97..62744547b8be 100644
--- a/include/linux/energy_model.h
+++ b/include/linux/energy_model.h
@@ -261,6 +261,7 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
unsigned long max_util, unsigned long sum_util,
unsigned long allowed_cpu_cap)
{
+ struct em_perf_table *runtime_table;
unsigned long freq, scale_cpu;
struct em_perf_state *ps;
int cpu, i;
@@ -278,7 +279,14 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
*/
cpu = cpumask_first(to_cpumask(pd->cpus));
scale_cpu = arch_scale_cpu_capacity(cpu);
- ps = &pd->table[pd->nr_perf_states - 1];
+
+ /*
+ * No rcu_read_lock() since it's already called by task scheduler.
+ * The runtime_table is always there for CPUs, so we don't check.
+ */
+ runtime_table = rcu_dereference(pd->runtime_table);
+
+ ps = &runtime_table->state[pd->nr_perf_states - 1];
max_util = map_util_perf(max_util);
max_util = min(max_util, allowed_cpu_cap);
@@ -288,9 +296,9 @@ static inline unsigned long em_cpu_energy(struct em_perf_domain *pd,
* Find the lowest performance state of the Energy Model above the
* requested frequency.
*/
- i = em_pd_get_efficient_state(pd->table, pd->nr_perf_states, freq,
- pd->flags);
- ps = &pd->table[i];
+ i = em_pd_get_efficient_state(runtime_table->state, pd->nr_perf_states,
+ freq, pd->flags);
+ ps = &runtime_table->state[i];
/*
* The capacity of a CPU in the domain at the performance state (ps)
--
2.25.1
Powered by blists - more mailing lists