linux-kernel - RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR11MB5751EB51168E04E186C33A72C13FA@DM8PR11MB5751.namprd11.prod.outlook.com>
Date:   Fri, 21 Jul 2023 16:39:10 +0000
From:   "Ng, Boon Khai" <boon.khai.ng@...el.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "Boon@...mtp.png.intel.com" <Boon@...mtp.png.intel.com>,
        "Khai@...mtp.png.intel.com" <Khai@...mtp.png.intel.com>,
        Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Shevchenko, Andriy" <andriy.shevchenko@...el.com>,
        "Tham, Mun Yew" <mun.yew.tham@...el.com>,
        "Swee, Leong Ching" <leong.ching.swee@...el.com>,
        "G Thomas, Rohan" <rohan.g.thomas@...el.com>,
        Shevchenko Andriy <andriy.shevchenko@...ux.intel.com>
Subject: RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings:
 net: snps,dwmac: Add description for rx-vlan-offload

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@...nel.org>
> Sent: Saturday, July 22, 2023 12:26 AM
> To: Ng, Boon Khai <boon.khai.ng@...el.com>; Boon@...mtp.png.intel.com;
> Khai@...mtp.png.intel.com; Giuseppe Cavallaro <peppe.cavallaro@...com>;
> Alexandre Torgue <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; David S . Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; netdev@...r.kernel.org; linux-stm32@st-
> md-mailman.stormreply.com; linux-arm-kernel@...ts.infradead.org; linux-
> kernel@...r.kernel.org
> Cc: Shevchenko, Andriy <andriy.shevchenko@...el.com>; Tham, Mun Yew
> <mun.yew.tham@...el.com>; Swee, Leong Ching
> <leong.ching.swee@...el.com>; G Thomas, Rohan
> <rohan.g.thomas@...el.com>; Shevchenko Andriy
> <andriy.shevchenko@...ux.intel.com>
> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-
> bindings: net: snps,dwmac: Add description for rx-vlan-offload
> 
> On 21/07/2023 17:28, Ng, Boon Khai wrote:
> > This is a new device bringup, thus the DT is not available yet. The
> > DTS will be upstreamed by my another colleague, unless, if I can upstream
> only my part on the setting?
> >
> >> Please kindly resend and include all necessary To/Cc entries.
> 
> To be clear, since you do not agree with my comment you skipped vital lists,
> this was not tested by automation so it is NAK from me.
> 
> Sorry.
> 

I understand that I already get a NAK at the beginning. But I don’t understand why,
Please don’t get me wrong, I'm not disagreeing your comments, was trying to understand
the reason behind and also which are the step that I made a mistake(s) on,  this is to help
me to learn at the same time to smoothen the upstreaming process.

> Best regards,
> Krzysztof