linux-kernel - Re: [PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as part of mmu_notifier_invalidate_range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLrciTXW9CfLCLar@ziepe.ca>
Date:   Fri, 21 Jul 2023 16:29:13 -0300
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Alistair Popple <apopple@...dia.com>
Cc:     akpm@...ux-foundation.org, ajd@...ux.ibm.com,
        catalin.marinas@....com, fbarrat@...ux.ibm.com,
        iommu@...ts.linux.dev, jhubbard@...dia.com, kevin.tian@...el.com,
        kvm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        linuxppc-dev@...ts.ozlabs.org, mpe@...erman.id.au,
        nicolinc@...dia.com, npiggin@...il.com, robin.murphy@....com,
        seanjc@...gle.com, will@...nel.org, x86@...nel.org,
        zhi.wang.linux@...il.com, sj@...nel.org
Subject: Re: [PATCH v3 4/5] mmu_notifiers: Don't invalidate secondary TLBs as
 part of mmu_notifier_invalidate_range_end()

On Thu, Jul 20, 2023 at 06:39:26PM +1000, Alistair Popple wrote:
> Secondary TLBs are now invalidated from the architecture specific TLB
> invalidation functions. Therefore there is no need to explicitly
> notify or invalidate as part of the range end functions. This means we
> can remove mmu_notifier_invalidate_range_end_only() and some of the
> ptep_*_notify() functions.
> 
> Signed-off-by: Alistair Popple <apopple@...dia.com>
> ---
>  include/linux/mmu_notifier.h | 56 +------------------------------------
>  kernel/events/uprobes.c      |  2 +-
>  mm/huge_memory.c             | 25 ++---------------
>  mm/hugetlb.c                 |  1 +-
>  mm/memory.c                  |  8 +----
>  mm/migrate_device.c          |  9 +-----
>  mm/mmu_notifier.c            | 25 ++---------------
>  mm/rmap.c                    | 40 +--------------------------
>  8 files changed, 14 insertions(+), 152 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason