linux-kernel - Re: [PATCH] drivers/scsi: Fix typos in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZLoCynrRoXHPn/Dx@debian.me>
Date:   Fri, 21 Jul 2023 11:00:10 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     pangzizhen001@...suo.com, oliver@...kum.org, aliakc@....de,
        lenehan@...bble.org, jejb@...ux.ibm.com, martin.petersen@...cle.com
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/scsi: Fix typos in comments

On Fri, Jul 21, 2023 at 12:06:11AM +0800, pangzizhen001@...suo.com wrote:
> Delete duplicate word "the"
> 
> Signed-off-by: Zizhen Pang <pangzizhen001@...suo.com>
> ---
>  drivers/scsi/dc395x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
> index c8e86f8a631e..077e76407c58 100644
> --- a/drivers/scsi/dc395x.c
> +++ b/drivers/scsi/dc395x.c
> @@ -2052,7 +2052,7 @@ static void data_in_phase0(struct AdapterCtlBlk *acb,
> struct ScsiReqBlk *srb,
>          /*
>           * KG: We should wait for the DMA FIFO to be empty ...
>           * but: it would be better to wait first for the SCSI FIFO and then
> the
> -         * the DMA FIFO to become empty? How do we know, that the device
> not already
> +         * DMA FIFO to become empty? How do we know, that the device not
> already
>           * sent data to the FIFO in a MsgIn phase, eg.?
>           */
>          if (!(DC395x_read8(acb, TRM_S1040_DMA_FIFOSTAT) & 0x80)) {

I'd like to write the comment above instead as "We should wait for the DMA
FIFO to be empty, but it would be better to wait first for the SCSI one and
then the DMA one to be emptied..."

But hey, you did not read review comments to all your submissions, many
of them (including mine) asking you to not corrupt your patches like this
one did.

Hence NAK from me.

Bye!

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)