[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230721164016.68bbe69a@gandalf.local.home>
Date: Fri, 21 Jul 2023 16:40:16 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Ajay Kaher <akaher@...are.com>
Cc: "shuah@...nel.org" <shuah@...nel.org>,
"mhiramat@...nel.org" <mhiramat@...nel.org>,
Ching-lin Yu <chinglinyu@...gle.com>,
linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-trace-kernel@...r.kernel.org, lkp@...el.com,
Nadav Amit <namit@...are.com>, oe-lkp@...ts.linux.dev,
Alexey Makhalov <amakhalov@...are.com>,
"er.ajay.kaher@...il.com" <er.ajay.kaher@...il.com>,
"srivatsa@...il.mit.edu" <srivatsa@...il.mit.edu>,
Tapas Kundu <tkundu@...are.com>,
Vasavi Sirnapalli <vsirnapalli@...are.com>
Subject: Re: [PATCH v4 00/10] tracing: introducing eventfs
On Fri, 21 Jul 2023 09:19:47 -0400
Steven Rostedt <rostedt@...dmis.org> wrote:
> > + } else {
> > + /* A race here, should try again (unless freed) */
> > + invalidate = true;
>
> I had a WARN_ON() once here. Probably could add a:
>
> WARN_ON_ONCE(!ef->is_freed);
Yeah this should have a WARN_ON_ONCE() because the only way to get here
with having a dentry and the ef->dentry being set is if we have two
dentries with the same name in the same directory. Which should never
happen.
I think we can add:
/*
* Should never happen unless we get here due to being freed.
* Otherwise it means two dentries exist with the same name.
*/
WARN_ON_ONCE(!ef->is_freed);
>
> > + }
-- Steve
Powered by blists - more mailing lists