[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <57d882ed-82e5-4584-8126-ca2007064126@lunn.ch>
Date: Sat, 22 Jul 2023 00:01:36 +0200
From: Andrew Lunn <andrew@...n.ch>
To: nick.hawkins@....com
Cc: verdun@....com, davem@...emloft.net, edumazet@...gle.com,
kuba@...nel.org, pabeni@...hat.com, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 3/5] dt-bindings: net: Add HPE GXP UMAC
> +examples:
> + - |
> + ethernet@...0 {
> + compatible = "hpe,gxp-umac";
> + reg = <0x4000 0x80>;
> + interrupts = <22>;
> + mac-address = [00 00 00 00 00 00]; /* Filled in by U-Boot */
Do both ports get the sane MAC address?
> + ethernet-ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + phy-handle = <ð_phy0>;
> + };
> +
> + port@1 {
> + reg = <1>;
> + phy-handle = <ð_phy1>;
> + };
> + };
> +
> + mdio {
This seems to be wrong. You have a standalone MDIO bus driver, not
part of the MAC address space?
Andrew
Powered by blists - more mailing lists