linux-kernel - RE: [EXT] Re: [net-next PATCH V3] octeontx2-af: Install TC filter rules in hardware based on priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <SJ0PR18MB52169A0F0DED59ED9BA62039DB3FA@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date:   Fri, 21 Jul 2023 04:33:57 +0000
From:   Suman Ghosh <sumang@...vell.com>
To:     Simon Horman <simon.horman@...igine.com>
CC:     Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula <gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linu Cherian <lcherian@...vell.com>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>
Subject: RE: [EXT] Re: [net-next PATCH V3] octeontx2-af: Install TC filter
 rules in hardware based on priority

>
>> @@ -729,22 +816,106 @@ static int otx2_del_mcam_flow_entry(struct
>otx2_nic *nic, u16 entry)
>>  		mutex_unlock(&nic->mbox.lock);
>>  		return -EFAULT;
>>  	}
>> +
>> +	if (cntr_val) {
>> +		rsp = (struct npc_delete_flow_rsp *)otx2_mbox_get_rsp(&nic-
>>mbox.mbox,
>> +								      0, &req->hdr);
>> +		*cntr_val = rsp->cntr_val;
>
>Hi Suman,
>
>otx2_mbox_get_rsp may return an ERR_PTR.
>Is it ok not to check that before dereferencing rsp?
[Suman] No, we should check for the err pointer. Thanks for pointing it out. Will update in v4
>
>> +	}
>> +
>>  	mutex_unlock(&nic->mbox.lock);
>> +	return 0;
>> +}
>
>...