[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230721054326.GO5194@atomide.com>
Date: Fri, 21 Jul 2023 08:43:26 +0300
From: Tony Lindgren <tony@...mide.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Andy Shevchenko <andriy.shevchenko@...el.com>,
Dhruva Gole <d-gole@...com>,
Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
John Ogness <john.ogness@...utronix.de>,
Johan Hovold <johan@...nel.org>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
Vignesh Raghavendra <vigneshr@...com>,
linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] serial: core: Controller id cannot be negative
* Greg Kroah-Hartman <gregkh@...uxfoundation.org> [230720 19:33]:
> On Thu, Jul 20, 2023 at 08:10:14AM +0300, Tony Lindgren wrote:
> > The controller id cannot be negative.
> >
>
> What does this mean for a changelog?
Just let's fix it while at it and adding port_id in the following patch.
If you prefer I can squash the change into the fix adding port_id.
> And you forgot to cc: linux-serial?
>
> And I never got patch 0/3?
>
> something went wrong here...
Thanks for letting me know, I'll check what went wrong..
> > Fixes: 84a9582fd203 ("serial: core: Start managing serial controllers to enable runtime PM")
> > Reported-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Closes: https://lore.kernel.org/linux-serial/ZLd154hdaSG2lnue@smile.fi.intel.com/#t
>
> This isn't a bug report to close, is it?
OK will leave it out. I added it as checkpatch.pl now warns if Reported-by
is added without Closes.
Regards,
Tony
Powered by blists - more mailing lists