linux-kernel - Re: Fwd: 6.4.4 breaks module-free builds of Debian kernel packages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <421602e6-0fe0-34c4-12bb-d805f2a282f4@leemhuis.info>
Date:   Fri, 21 Jul 2023 08:11:02 +0200
From:   "Linux regression tracking (Thorsten Leemhuis)" 
        <regressions@...mhuis.info>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Bagas Sanjaya <bagasdotme@...il.com>,
        Josh Triplett <josh@...htriplett.org>,
        Nicolas Schier <nicolas@...sle.eu>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Sasha Levin <sashal@...nel.org>,
        Brian Lindholm <brian_lindholm@...rs.sourceforge.net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Regressions <regressions@...ts.linux.dev>,
        Linux Stable <stable@...r.kernel.org>,
        Linux Kernel Build System <linux-kbuild@...r.kernel.org>
Subject: Re: Fwd: 6.4.4 breaks module-free builds of Debian kernel packages

On 21.07.23 06:13, Randy Dunlap wrote:
> On 7/20/23 20:18, Bagas Sanjaya wrote:
>>
>>> I'm on AMD64 with Debian testing (trixie), where I build my own kernels (with CONFIG_MODULES unset) using "make bindeb-pkg". The build proceeds through 99% of the process, but fails here:
>>>
> [...]
>>>
>>> 6.3.13 contained the same error, but I "fixed" that by moving to 6.4.3.  But alas, 6.4.4 now has the same issue.
>>>
>>> I worked around the issue by changing "exit 1" to "exit 0" in the main Makefile (at "modules module_install", per the attached patch), but I don't know if this is a true fix or something that simply happens to work for my particular configuration.
>>
>> See Bugzilla for the full thread and attached patch that ignores the error.
>>
>> Josh: It looks like this regression is caused by a commit of yours
>> (and also 1240dabe8d58b4). Would you like to take a look on it?
>>
>> Anyway, I'm adding this regression to be tracked by regzbot:
>>
>> #regzbot introduced: 4243afdb932677 https://bugzilla.kernel.org/show_bug.cgi?id=217689
>> #regzbot title: always doing modules_install breaks CONFIG_MODULES=n builds

Masahiro Yamada: thx for taking care of this and Greg for picking the
fix up.

BTW, Bagas, this apparently is a regression that only affected stable.
In that case please tell rezbot about the stable commit-id of the
change, as otherwise it will consider the problem a regression in
mainline (and there it's was never a problem or already solved [didn't
look]).

Let me fix this up and tell regzbot about the incoming fix while at it:

#regzbot introduced: 6061ac50f1e04
#regzbot fix: kbuild: make modules_install copy modules.builtin(.modinfo)

>> [1]: https://bugzilla.kernel.org/show_bug.cgi?id=217689
> 
> Do you also take care of marking the bugzilla entries as completed/fixed/solved
> etc.?

I don't known if Bagas does, but I do not and have no plans to do so.

I consider my work on looking at bugzilla for regressions a courtesy I
perform in the interest of the "no regressions" rule, as some or many of
those report otherwise will be ignored. And that's bad for our reputation.

But that is where my courtesy stops. Those that think having a bugzilla
around should take care of maintaining the state. Bugbot might soon
solve part of the problem. But I guess it won't handle this case.

Ciao, Thorsten