linux-kernel - Re: [PATCH 8/8] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202307211455.rru56Ub2-lkp@intel.com>
Date:   Fri, 21 Jul 2023 14:46:36 +0800
From:   kernel test robot <lkp@...el.com>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de
Cc:     oe-kbuild-all@...ts.linux.dev, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, aisheng.dong@....com,
        alexander.stein@...tq-group.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Ranjani Vaidyanathan <ranjani.vaidyanathan@....com>,
        Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 8/8] firmware: imx: scu-irq: support identifying SCU
 wakeup source from sysfs

Hi Peng,

kernel test robot noticed the following build warnings:

[auto build test WARNING on shawnguo/for-next]
[also build test WARNING on linus/master v6.5-rc2 next-20230721]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/firmware-imx-scu-change-init-level-to-subsys_initcall_sync/20230720-174508
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next
patch link:    https://lore.kernel.org/r/20230720094128.536388-9-peng.fan%40oss.nxp.com
patch subject: [PATCH 8/8] firmware: imx: scu-irq: support identifying SCU wakeup source from sysfs
config: arm64-randconfig-r003-20230720 (https://download.01.org/0day-ci/archive/20230721/202307211455.rru56Ub2-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307211455.rru56Ub2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307211455.rru56Ub2-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/firmware/imx/imx-scu-irq.c: In function 'wakeup_source_show':
>> drivers/firmware/imx/imx-scu-irq.c:179:16: warning: variable 'size' set but not used [-Wunused-but-set-variable]
     179 |         int i, size;
         |                ^~~~


vim +/size +179 drivers/firmware/imx/imx-scu-irq.c

   175	
   176	static ssize_t wakeup_source_show(struct kobject *kobj,
   177						struct kobj_attribute *attr, char *buf)
   178	{
 > 179		int i, size;
   180	
   181		for (i = 0; i < IMX_SC_IRQ_NUM_GROUP; i++) {
   182			if (!scu_irq_wakeup[i].wakeup_src)
   183				continue;
   184	
   185			if (scu_irq_wakeup[i].valid)
   186				size = sprintf(buf, "Wakeup source group = %d, irq = 0x%x\n",
   187					       i, scu_irq_wakeup[i].wakeup_src);
   188			else
   189				size = sprintf(buf, "Spurious SCU wakeup, group = %d, irq = 0x%x\n",
   190					       i, scu_irq_wakeup[i].wakeup_src);
   191		}
   192	
   193		return strlen(buf);
   194	}
   195	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki