[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <3319d61a-08df-42c0-8882-5d4c9037f5e3@kadam.mountain>
Date: Fri, 21 Jul 2023 09:59:52 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Miquel Raynal <miquel.raynal@...tlin.com>,
Richard Weinberger <richard@....at>,
Vignesh Raghavendra <vigneshr@...com>,
Boris Brezillon <boris.brezillon@...labora.com>,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
linux-mtd@...ts.infradead.org, Julia Lawall <Julia.Lawall@...6.fr>,
Harshit Mogalapalli <harshit.m.mogalapalli@...il.com>
Subject: Re: [PATCH] mtd: rawnand: fsl_upm: Fix an off-by one test in
fun_exec_op()
On Fri, Jul 21, 2023 at 09:55:02AM +0300, Dan Carpenter wrote:
> On Fri, Jul 21, 2023 at 08:37:02AM +0300, Dan Carpenter wrote:
> > Harshit and I were mucking with this about yesterday. He made
> > Coccinelle script as well.
> >
> > We found three bugs in max9286_parse_dt(), hisi_inno_phy_probe() and
> > jent_testing_store(). Only the one in hisi_inno_phy_probe() is real
> > life bad because the others do an out of bounds check followed by a
> > mask.
>
> Actually wait. hisi_inno_phy_probe() is not a bug at all.
> MAX9286_NUM_GMSL and MAX9286_NUM_GMSL are both 4.
Gar, wow. hisi_inno_phy_probe() is a bug. max9286_parse_dt() is not
a bug.
Smatch would have found max9286_parse_dt() if it had been a bug. The
reason why smatch didn't find hisi_inno_phy_probe() is because of how
Smatch takes a short cut when parsing loops.
regards,
dan carpenter
Powered by blists - more mailing lists