linux-kernel - Re: [PATCH 1/2] mm/compaction: correct comment of candidate pfn in fast_isolate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 15:44:12 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Baolin Wang <baolin.wang@...ux.alibaba.com>
Subject: Re: [PATCH 1/2] mm/compaction: correct comment of candidate pfn in
 fast_isolate_freepages

Hi Baolin, I try to resend a new v2 patchset, the patch 1 is still
missing. Here is the patch 1 in old version and I find it in lore
archive of lore.kernel.org with link [1].
It's likely that patch 1 is denied by linux-mm.kvack.org but accepted
by linux-kernel@...r.kernel.org. Is anyone know how to submit issue of
linux-mm.kvack.org, please let know. Thanks!

[1] https://lore.kernel.org/all/20230720115351.2039431-2-shikemeng@huaweicloud.com/

on 7/20/2023 7:53 PM, Kemeng Shi wrote:
> If no preferred one was not found, we will use candidate page with maximum
> pfn > min_pfn which is saved in high_pfn. Correct "minimum" to "maximum
> candidate" in comment.
> 
> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com>
> ---
>  mm/compaction.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/compaction.c b/mm/compaction.c
> index eb1d3d9a422c..c0d8d08fc163 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -1526,7 +1526,7 @@ static void fast_isolate_freepages(struct compact_control *cc)
>  				break;
>  		}
>  
> -		/* Use a minimum pfn if a preferred one was not found */
> +		/* Use a maximum candidate pfn if a preferred one was not found */
>  		if (!page && high_pfn) {
>  			page = pfn_to_page(high_pfn);
>  
> 

-- 
Best wishes
Kemeng Shi