linux-kernel - Re: [PATCH v1 0/8] iio: core: A few code cleanups and documentation fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d65e25da75142b7414cbf082c7f485464b82b6d1.camel@gmail.com>
Date:   Fri, 21 Jul 2023 10:06:05 +0200
From:   Nuno Sá <noname.nuno@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH v1 0/8] iio: core: A few code cleanups and documentation
 fixes

On Thu, 2023-07-20 at 23:53 +0300, Andy Shevchenko wrote:
> Just set of almost unrelated to each other cleanups against IIO
> core implementation.
> 
> The positive LoCs diffstat due to first patch that adds a lot of
> documentation for the new added macro.
> 
> Andy Shevchenko (8):
>   iio: core: Add opaque_struct_size() helper and use it
>   iio: core: Use sysfs_match_string() helper
>   iio: core: Switch to krealloc_array()
>   iio: core: Use min() instead of min_t() to make code more robust
>   iio: core: Get rid of redundant 'else'
>   iio: core: Fix issues and style of the comments
>   iio: core: Move initcalls closer to the respective calls
>   iio: core: Improve indentation in a few places
> 
>  drivers/iio/industrialio-core.c | 226 ++++++++++++++++----------------
>  1 file changed, 115 insertions(+), 111 deletions(-)
> 

Neat series... Just a few comments on my side and on patch 3 is up to you to
take the comments or not.

With my comment addressed on patch 2:

Reviewed-by: Nuno Sa <nuno.sa@...log.com>