linux-kernel - Re: [PATCH v2] ARM: multi_v7_defconfig: Enable OMAP watchdog support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 10:24:11 +0200
From:   Julien Panis <jpanis@...libre.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        vigneshr@...com, afd@...com
Subject: Re: [PATCH v2] ARM: multi_v7_defconfig: Enable OMAP watchdog support

On 7/21/23 09:38, Tony Lindgren wrote:
> * Julien Panis <jpanis@...libre.com> [230719 10:09]:
>> On 7/18/23 16:58, Julien Panis wrote:
>>> Increase build and test coverage by enabling support for OMAP watchdog,
>>> as used on TI OMAP based boards.
>>>
>>> The watchdog timer is an upward counter capable of generating a pulse on
>>> the reset pin and an interrupt to the device system modules following an
>>> overflow condition.
>>>
>>> Signed-off-by: Julien Panis <jpanis@...libre.com>
> Looks good to me:
>
> Reviewed-by: Tony Lindgren <tony@...mide.com>
>
>> Maybe this patch should not be applied actually. I have 2 questions:
>>
>> [Q1] Using the following cmd sequence leads to a modified 'multi_v7_defconfig' file:
>>        'make multi_v7_defconfig'
>>        'make savedefconfig'
>>        'mv defconfig arch/arm/configs/multi_v7_defconfig'
>> ...even without modifying CONFIG_OMAP_WATCHDOG flag.
>> I guess it's due to modifications in various Kconfig files (dependencies for instance).
>> And perhaps it's also due to previous modifications of 'multi_v7_defconfig' file that
>> were not done by using 'make savedefconfig' (?)
>> How should I handle that for this patch ? This v2 has been created by modifying
>> 'multi_v7_defconfig' file manually. Using 'make savedefconfig' would be cleaner,
>> but as a result many flags would be re-organized whereas the commit intends to
>> enable 1 flag only.
> After make savedefconfig you can take a look where the new option got placed
> and then throw away the changes and add the entry manually :)
>
>> [Q2] I would like to add another flag in order to enable CONFIG_RTC_DRV_OMAP.
>> Is it better grouping CONFIG_OMAP_WATCHDOG and CONFIG_RTC_DRV_OMAP in
>> a single commit ? What's recommended ?
> Adding both is fine for the defconfig change, just try to place them where
> they would end up after savedefconfig to avoid it getting more out of sync.
>
> Regards,
>
> Tony

OK, thank you for these explanations.
There will be other flags to add (much more than 2 actually !). So, it's not worth merging
this patch. I will send another patch with all the flags that must be set.

Julien