[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea531ba80db67cccb03ea173e714fe868f869e91.camel@mediatek.com>
Date: Fri, 21 Jul 2023 08:46:19 +0000
From: Yi-De Wu (吳一德) <Yi-De.Wu@...iatek.com>
To: "corbet@....net" <corbet@....net>,
"angelogioacchino.delregno@...labora.com"
<angelogioacchino.delregno@...labora.com>,
"krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
"catalin.marinas@....com" <catalin.marinas@....com>,
Yingshiuan Pan (潘穎軒)
<Yingshiuan.Pan@...iatek.com>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
"arnd@...db.de" <arnd@...db.de>,
Ze-yu Wang (王澤宇)
<Ze-yu.Wang@...iatek.com>, "will@...nel.org" <will@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
"robh+dt@...nel.org" <robh+dt@...nel.org>,
MY Chuang (莊明躍) <MY.Chuang@...iatek.com>,
"quic_tsoni@...cinc.com" <quic_tsoni@...cinc.com>,
"conor.dooley@...rochip.com" <conor.dooley@...rochip.com>,
PeiLun Suei (隋培倫)
<PeiLun.Suei@...iatek.com>,
Liju-clr Chen (陳麗如)
<Liju-clr.Chen@...iatek.com>,
Jades Shih (施向玨)
<jades.shih@...iatek.com>,
"conor+dt@...nel.org" <conor+dt@...nel.org>,
"dbrazdil@...gle.com" <dbrazdil@...gle.com>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"krzysztof.kozlowski+dt@...aro.org"
<krzysztof.kozlowski+dt@...aro.org>,
Shawn Hsiao (蕭志祥)
<shawn.hsiao@...iatek.com>,
"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
Ivan Tseng (曾志軒)
<ivan.tseng@...iatek.com>,
Chi-shen Yeh (葉奇軒)
<Chi-shen.Yeh@...iatek.com>
Subject: Re: [PATCH v4 2/9] virt: geniezone: Add GenieZone hypervisor support
On Fri, 2023-06-09 at 17:22 +0200, Krzysztof Kozlowski wrote:
>
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> On 09/06/2023 10:52, Yi-De Wu wrote:
> > From: "Yingshiuan Pan" <yingshiuan.pan@...iatek.com>
> >
> > GenieZone is MediaTek hypervisor solution, and it is running in EL2
> > stand alone as a type-I hypervisor. This patch exports a set of
> ioctl
> > interfaces for userspace VMM (e.g., crosvm) to operate guest VMs
> > lifecycle (creation and destroy) on GenieZone.
>
> ...
>
> > +static int gzvm_drv_probe(void)
> > +{
> > +int ret;
> > +
> > +if (gzvm_arch_probe() != 0) {
> > +pr_err("Not found available conduit\n");
> > +return -ENODEV;
> > +}
> > +
> > +ret = misc_register(&gzvm_dev);
> > +if (ret)
> > +return ret;
> > +gzvm_debug_dev = &gzvm_dev;
> > +
> > +return 0;
> > +}
> > +
> > +static int gzvm_drv_remove(void)
> > +{
> > +destroy_all_vm();
> > +misc_deregister(&gzvm_dev);
> > +return 0;
> > +}
> > +
> > +static int gzvm_dev_init(void)
> > +{
> > +return gzvm_drv_probe();
>
> So for every system and architecture you want to: probe, run some SMC
> and then print error that it is not othe system you wanted.
>
> I don't think this is what we want. You basically pollute all of
> other
> users just to have your hypervisor guest additions...
>
>
> Best regards,
> Krzysztof
hi Krzysztof,
After some back-and-forth discussion[1][2][3][4][5], we'd like to bring
bakc all the attension of related issues in this thread.
We're going to restore the dt solution on our next version, which means
we would maintain a simple dt for discovering the hypervisor node and
probe for the status of the device when needed.
The reasons are listed below for the record.
- Although dt is for hardware, it's difficult to discover a specific
hypervisor without probing on all subsystem and thus pollute all of
other users[4] as a consequence.
- The GenieZone hypervisor could be considered as a vendor model to
assist platform virtualization whose implementation is independent from
Linuxism.
Please let us if there're any other concerns.
Reference
[1]
https://android-review.googlesource.com/c/kernel/common/+/2447547/comment/495502f3_bb52344b/
[2]
https://lore.kernel.org/all/20230428212411.GA292303-robh@kernel.org/
[3]
https://lore.kernel.org/all/ec4cae2e6da4a64bc3983ffdde03f51e185d3609.camel@mediatek.com/
[4]
https://lore.kernel.org/lkml/2fe0c7f9-55fc-ae63-3631-8526a0212ccd@linaro.org/
[5]
https://lore.kernel.org/all/14c0381be38ea40fcd03104bff32bcaa09b920d3.camel@mediatek.com/
Regards,
>
Powered by blists - more mailing lists