[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZLpOTTrYTxfMqYen@corigine.com>
Date: Fri, 21 Jul 2023 10:22:21 +0100
From: Simon Horman <simon.horman@...igine.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: linux-crypto@...r.kernel.org,
Herbert Xu <herbert@...dor.apana.org.au>,
Eric Biggers <ebiggers@...nel.org>,
Kees Cook <keescook@...omium.org>,
Haren Myneni <haren@...ibm.com>,
Nick Terrell <terrelln@...com>,
Minchan Kim <minchan@...nel.org>,
Sergey Senozhatsky <senozhatsky@...omium.org>,
Jens Axboe <axboe@...nel.dk>,
Giovanni Cabiddu <giovanni.cabiddu@...el.com>,
Richard Weinberger <richard@....at>,
David Ahern <dsahern@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Steffen Klassert <steffen.klassert@...unet.com>,
linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
qat-linux@...el.com, linuxppc-dev@...ts.ozlabs.org,
linux-mtd@...ts.infradead.org, netdev@...r.kernel.org
Subject: Re: [RFC PATCH 08/21] zram: Migrate to acomp compression API
On Tue, Jul 18, 2023 at 02:58:34PM +0200, Ard Biesheuvel wrote:
...
> @@ -1618,9 +1614,7 @@ static int zram_recompress(struct zram *zram, u32 index, struct page *page,
>
> num_recomps++;
> zstrm = zcomp_stream_get(zram->comps[prio]);
> - src = kmap_atomic(page);
> - ret = zcomp_compress(zstrm, src, &comp_len_new);
> - kunmap_atomic(src);
> + ret = zcomp_compress(zstrm, page, &comp_len_new);
Hi Ard,
src appears to be unused in this function with this change.
>
> if (ret) {
> zcomp_stream_put(zram->comps[prio]);
...
Powered by blists - more mailing lists