[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230721094343.25741-1-aboutphysycs@gmail.com>
Date: Fri, 21 Jul 2023 12:43:43 +0300
From: Andrei Coardos <aboutphysycs@...il.com>
To: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Cc: andy@...nel.org, brgl@...ev.pl, linus.walleij@...aro.org,
Andrei Coardos <aboutphysycs@...il.com>,
Alexandru Ardelean <alex@...uggie.ro>
Subject: [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata()
This function call was found to be unnecessary as there is no equivalent
platform_get_drvdata() call to access the private data of the driver.
Also, the private data is defined in this driver, so there is no risk of
it being accessed outside of this driver file.
Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>
Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
---
drivers/gpio/gpio-lp873x.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpio/gpio-lp873x.c b/drivers/gpio/gpio-lp873x.c
index 5c79ba1f229c..7427a74ce4e2 100644
--- a/drivers/gpio/gpio-lp873x.c
+++ b/drivers/gpio/gpio-lp873x.c
@@ -140,8 +140,6 @@ static int lp873x_gpio_probe(struct platform_device *pdev)
if (!gpio)
return -ENOMEM;
- platform_set_drvdata(pdev, gpio);
-
gpio->lp873 = dev_get_drvdata(pdev->dev.parent);
gpio->chip = template_chip;
gpio->chip.parent = gpio->lp873->dev;
--
2.34.1
Powered by blists - more mailing lists