linux-kernel - Re: [PATCH v3 3/3] serial: core: Fix serial core controller port name to show controller id

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLpfgcDD6UeOAh/e@smile.fi.intel.com>
Date:   Fri, 21 Jul 2023 13:35:45 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, Dhruva Gole <d-gole@...com>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        John Ogness <john.ogness@...utronix.de>,
        Johan Hovold <johan@...nel.org>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-omap@...r.kernel.org
Subject: Re: [PATCH v3 3/3] serial: core: Fix serial core controller port
 name to show controller id

On Fri, Jul 21, 2023 at 10:21:42AM +0300, Tony Lindgren wrote:
> We are missing the serial core controller id for the serial core port
> name. Let's fix the issue for sane /sys/bus/serial-core/devices, and to
> avoid issues addressing serial ports later on.

...

> +	if (type == &serial_ctrl_type)
> +		return dev_set_name(dev, "%s.%s.%d", type->name,

> +	else if (type == &serial_port_type)
> +		return dev_set_name(dev, "%s.%s.%d.%d", type->name,
> +				    dev_name(port->dev), ctrl_id,
> +				    port_id);
> +	else

Redundant 'else' in both cases.

> +		return -EINVAL;

-- 
With Best Regards,
Andy Shevchenko