linux-kernel - Re: [PATCH v6 2/3] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLpu72xDla42x7J8@francesco-nb.int.toradex.com>
Date:   Fri, 21 Jul 2023 13:41:35 +0200
From:   Francesco Dolcini <francesco@...cini.it>
To:     James Hilliard <james.hilliard1@...il.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        devicetree@...r.kernel.org,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Marek Vasut <marex@...x.de>,
        Frieder Schrempf <frieder.schrempf@...tron.de>,
        Stefan Wahren <stefan.wahren@...rgebyte.com>,
        Philippe Schenker <philippe.schenker@...adex.com>,
        Andreas Kemnade <andreas@...nade.info>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Christoph Niedermaier <cniedermaier@...electronics.com>,
        Li Yang <leoyang.li@....com>, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v6 2/3] ARM: dts: imx6qdl: Add Variscite VAR-SOM-MX6 SoM
 support

On Fri, Jul 21, 2023 at 05:05:51AM -0600, James Hilliard wrote:
> On Fri, Jul 21, 2023 at 4:43 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
> > On 21/07/2023 12:33, James Hilliard wrote:
> > > +             compatible = "regulator-fixed";
> > > +             regulator-name = "touch_3v3_supply";
> > > +             regulator-always-on;
> >
> > Also, missing constraints.
> 
> Hmm, what's the correct way to determine the constraint values?

You should know/understand the hardware design. Normally when writing a
DT file you have the hardware schematics and the relevant datasheets
available.

> I'm guessing they should just be set to this based on the name?:
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;

This looks like a good guess, assuming that the regulator name is
correct.

Francesco