linux-kernel - Re: [PATCH v2] tools/counter: Makefile: Replace rmdir by rm to avoid make,clean failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 09:10:26 -0400
From:   William Breathitt Gray <wbg@...nel.org>
To:     Anh Tuan Phan <tuananhlfc@...il.com>
Cc:     william.gray@...aro.org, rongtao@...tc.cn, ricardo@...dini.net,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-kernel-mentees 
        <linux-kernel-mentees@...ts.linuxfoundation.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] tools/counter: Makefile: Replace rmdir by rm to avoid
 make,clean failure

On Sun, Jul 16, 2023 at 10:44:56PM +0700, Anh Tuan Phan wrote:
> Use rm -df instead of rmdir -p since rmdir requires the directory exist
> so it causes "make -C tools clean" failed if someone only builds other
> tools but not counter.
> 
> Fixes: 228354ed692f ("tools/counter: Makefile: Remove lingering
> 'include' directories on make clean")

Hi Anh,

Tags should span a single line even if they are long. This is minor
enough that I will clean it as I pick up the patch so no need to worry
about it this time. In the future, run script/checkpatch.pl on your
patches to catch these type of mistakes that are easy to miss.

I'll queue this patch for the counter-fixes branch.

Thanks,

William Breathitt Gray

> Signed-off-by: Anh Tuan Phan <tuananhlfc@...il.com>
> ---
> Changes from v1:
> - Use rm -df instead of checking the directory exists
> - Add Fixes tag
> - Update the patch title
> Reference:
> - v1:
> https://lore.kernel.org/all/362e127d-6018-5fc6-247b-3c729b99d946@gmail.com/
> ---
>  tools/counter/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/counter/Makefile b/tools/counter/Makefile
> index a0f4cab71fe5..b2c2946f44c9 100644
> --- a/tools/counter/Makefile
> +++ b/tools/counter/Makefile
> @@ -40,7 +40,8 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
>  clean:
>  	rm -f $(ALL_PROGRAMS)
>  	rm -rf $(OUTPUT)include/linux/counter.h
> -	rmdir -p $(OUTPUT)include/linux
> +	rm -df $(OUTPUT)include/linux
> +	rm -df $(OUTPUT)include
>  	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
> 
>  install: $(ALL_PROGRAMS)
> -- 
> 2.34.1

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)