linux-kernel - Re: [PATCH] drm/bridge: Add debugfs print for bridge chains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202307212102.Fxrv1Ayx-lkp@intel.com>
Date:   Fri, 21 Jul 2023 21:28:32 +0800
From:   kernel test robot <lkp@...el.com>
To:     Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
        Andrzej Hajda <andrzej.hajda@...el.com>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Robert Foss <rfoss@...nel.org>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Francesco Dolcini <francesco.dolcini@...adex.com>,
        Aradhya Bhatia <a-bhatia1@...com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        Tomi Valkeinen <tomi.valkeinen@...asonboard.com>,
        linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] drm/bridge: Add debugfs print for bridge chains

Hi Tomi,

kernel test robot noticed the following build errors:

[auto build test ERROR on c7a472297169156252a50d76965eb36b081186e2]

url:    https://github.com/intel-lab-lkp/linux/commits/Tomi-Valkeinen/drm-bridge-Add-debugfs-print-for-bridge-chains/20230721-174615
base:   c7a472297169156252a50d76965eb36b081186e2
patch link:    https://lore.kernel.org/r/20230721-drm-bridge-chain-debugfs-v1-1-8614ff7e890d%40ideasonboard.com
patch subject: [PATCH] drm/bridge: Add debugfs print for bridge chains
config: x86_64-randconfig-r032-20230720 (https://download.01.org/0day-ci/archive/20230721/202307212102.Fxrv1Ayx-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230721/202307212102.Fxrv1Ayx-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202307212102.Fxrv1Ayx-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/gpu/drm/drm_bridge.c: In function 'drm_bridge_chains_info':
>> drivers/gpu/drm/drm_bridge.c:1371:35: error: 'struct drm_bridge' has no member named 'of_node'
    1371 |                         if (bridge->of_node)
         |                                   ^~
   drivers/gpu/drm/drm_bridge.c:1372:70: error: 'struct drm_bridge' has no member named 'of_node'
    1372 |                                 drm_printf(&p, ", OF: %pOFfc", bridge->of_node);
         |                                                                      ^~


vim +1371 drivers/gpu/drm/drm_bridge.c

  1349	
  1350	#ifdef CONFIG_DEBUG_FS
  1351	static int drm_bridge_chains_info(struct seq_file *m, void *data)
  1352	{
  1353		struct drm_debugfs_entry *entry = m->private;
  1354		struct drm_device *dev = entry->dev;
  1355		struct drm_printer p = drm_seq_file_printer(m);
  1356		struct drm_mode_config *config = &dev->mode_config;
  1357		struct drm_encoder *encoder;
  1358		unsigned int bridge_idx = 0;
  1359	
  1360		list_for_each_entry(encoder, &config->encoder_list, head) {
  1361			struct drm_bridge *bridge;
  1362	
  1363			drm_printf(&p, "encoder[%u]\n", encoder->base.id);
  1364	
  1365			bridge = drm_bridge_chain_get_first_bridge(encoder);
  1366	
  1367			while (bridge) {
  1368				drm_printf(&p, "\tbridge[%u] type: %u, ops: %#x",
  1369					   bridge_idx, bridge->type, bridge->ops);
  1370	
> 1371				if (bridge->of_node)
  1372					drm_printf(&p, ", OF: %pOFfc", bridge->of_node);
  1373	
  1374				drm_printf(&p, "\n");
  1375	
  1376				bridge_idx++;
  1377				bridge = drm_bridge_get_next_bridge(bridge);
  1378			}
  1379		}
  1380	
  1381		return 0;
  1382	}
  1383	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki