linux-kernel - Re: [PATCH] watchdog: advantech_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3ea7f3f3-c153-4ee9-98e4-5f01de0ac88c@roeck-us.net>
Date:   Fri, 21 Jul 2023 06:42:00 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Florent CARLI <fcarli@...il.com>
Cc:     Wim Van Sebroeck <wim@...ux-watchdog.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yoann Congal <yoann.congal@...le.fr>
Subject: Re: [PATCH] watchdog: advantech_ec_wdt: fix Kconfig dependencies

On Fri, Jul 21, 2023 at 10:13:47AM +0200, Florent CARLI wrote:
> This driver uses the WATCHDOG_CORE framework and ISA_BUS_API.
> This commit has these dependencies correctly selected.
> 
> Signed-off-by: Florent CARLI <fcarli@...il.com>
> Co-authored-by: Yoann Congal <yoann.congal@...le.fr>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index ee97d89dfc11..2108283b438c 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1075,6 +1075,8 @@ config ADVANTECH_WDT
>  config ADVANTECH_EC_WDT
>  	tristate "Advantech Embedded Controller Watchdog Timer"
>  	depends on X86
> +	select ISA_BUS_API
> +	select WATCHDOG_CORE
>  	help
>  		This driver supports Advantech products with ITE based Embedded Controller.
>  		It does not support Advantech products with other ECs or without EC.
> -- 
> 2.39.2 (Apple Git-143)
>