linux-kernel - Re: [PATCH -next] phy: Remove duplicated include in xusb.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 15:55:35 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Yang Li <yang.lee@...ux.alibaba.com>,
        Vinod Koul <vkoul@...nel.org>,
        Kishon Vijay Abraham I <kishon@...nel.org>
Cc:     jckuo@...dia.com, jonathanh@...dia.com,
        linux-phy@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] phy: Remove duplicated include in xusb.c

On Wed, Jul 19, 2023 at 08:36:14AM +0800, Yang Li wrote:
> ./drivers/phy/tegra/xusb.c: linux/platform_device.h is included more than once.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5930
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/phy/tegra/xusb.c | 1 -
>  1 file changed, 1 deletion(-)

It's typical to list the maintainers on the "To:" line to increase the
chances of them noticing. This is obviously correct, so:

Acked-by: Thierry Reding <treding@...dia.com>

> 
> diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c
> index ed30866e7647..142ebe0247cc 100644
> --- a/drivers/phy/tegra/xusb.c
> +++ b/drivers/phy/tegra/xusb.c
> @@ -12,7 +12,6 @@
>  #include <linux/phy/phy.h>
>  #include <linux/phy/tegra/xusb.h>
>  #include <linux/platform_device.h>
> -#include <linux/platform_device.h>
>  #include <linux/regulator/consumer.h>
>  #include <linux/reset.h>
>  #include <linux/slab.h>
> -- 
> 2.20.1.7.g153144c
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)