linux-kernel - Re: [PATCH v1] xfrm: add NULL check in xfrm_update_ae

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZLqTe9XroSlOs+39@corigine.com>
Date:   Fri, 21 Jul 2023 15:17:31 +0100
From:   Simon Horman <simon.horman@...igine.com>
To:     Lin Ma <linma@....edu.cn>
Cc:     steffen.klassert@...unet.com, herbert@...dor.apana.org.au,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] xfrm: add NULL check in xfrm_update_ae_params

On Fri, Jul 21, 2023 at 09:44:11AM +0800, Lin Ma wrote:
> Normally, x->replay_esn and x->preplay_esn should be allocated at
> xfrm_alloc_replay_state_esn(...) in xfrm_state_construct(..), hence the
> frm_update_ae_params(...) is okay to update them. However, the current
> impelementation of xfrm_new_ae(...) allows a malicious user to directly

nit: impelementation -> implementation

...