linux-kernel - Re: [PATCH] s390: use obj-y to descend into drivers/s390/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <01972a94-fc21-709e-29ac-847b8e60ee23@linux.ibm.com>
Date:   Fri, 21 Jul 2023 16:36:03 +0200
From:   Christian Borntraeger <borntraeger@...ux.ibm.com>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>, linux-s390@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH] s390: use obj-y to descend into drivers/s390/

Am 21.07.23 um 15:41 schrieb Masahiro Yamada:
> I like to use obj-y in as many places as possible.

Please do not use "I like". That is just too polite.

This fixes a bug as outlined below and maybe make it a clear statement that the current use is
non-standard and needs to be fixed - I think.
> 
> Change the drivers-y to obj-y. It moves the objects from drivers/s390/
> to slightly lower address, but fixes the single build issue. [1]
> 
> [1]: https://lore.kernel.org/linux-kbuild/d57ba55f-20a3-b836-783d-b49c8a161b6e@kernel.org/T/#m27f781ab60acadfed8a9e9642f30d5414a5e2df3
> 
> Signed-off-by: Masahiro Yamada <masahiroy@...nel.org>
> Tested-by: Jiri Slaby <jirislaby@...nel.org>
> ---
> 
>   arch/s390/Makefile | 1 -
>   drivers/Makefile   | 2 ++
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/s390/Makefile b/arch/s390/Makefile
> index 5ed242897b0d..a53a36ee0731 100644
> --- a/arch/s390/Makefile
> +++ b/arch/s390/Makefile
> @@ -119,7 +119,6 @@ export KBUILD_CFLAGS_DECOMPRESSOR
>   OBJCOPYFLAGS	:= -O binary
>   
>   libs-y		+= arch/s390/lib/
> -drivers-y	+= drivers/s390/
>   
>   boot		:= arch/s390/boot
>   syscalls	:= arch/s390/kernel/syscalls
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 7241d80a7b29..a7459e77df37 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -195,3 +195,5 @@ obj-$(CONFIG_PECI)		+= peci/
>   obj-$(CONFIG_HTE)		+= hte/
>   obj-$(CONFIG_DRM_ACCEL)		+= accel/
>   obj-$(CONFIG_CDX_BUS)		+= cdx/
> +
> +obj-$(CONFIG_S390)		+= s390/