[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20230721234355.b0a7ae245a2010d4a5c08a52@kernel.org>
Date: Fri, 21 Jul 2023 23:43:55 +0900
From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
To: Arnaldo Carvalho de Melo <acme@...nel.org>
Cc: Namhyung Kim <namhyung@...nel.org>, Ingo Molnar <mingo@...nel.org>,
Thomas Gleixner <tglx@...utronix.de>,
Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
Adrian Hunter <adrian.hunter@...el.com>,
Clark Williams <williams@...hat.com>,
Kate Carcia <kcarcia@...hat.com>, linux-kernel@...r.kernel.org,
linux-perf-users@...r.kernel.org,
Arnaldo Carvalho de Melo <acme@...hat.com>,
Andre Fredette <anfredet@...hat.com>,
Dave Tucker <datucker@...hat.com>,
Derek Barbosa <debarbos@...hat.com>,
Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH 2/5] perf bench uprobe: Print diff to baseline
On Wed, 19 Jul 2023 17:49:07 -0300
Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> From: Arnaldo Carvalho de Melo <acme@...hat.com>
>
> This is just prep work to show the diff to the unmodified workload.
Looks good to me, just one comment below.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
>
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Andre Fredette <anfredet@...hat.com>
> Cc: Clark Williams <williams@...hat.com>
> Cc: Dave Tucker <datucker@...hat.com>
> Cc: Derek Barbosa <debarbos@...hat.com>
> Cc: Ian Rogers <irogers@...gle.com>
> Cc: Jiri Olsa <jolsa@...nel.org>
> Cc: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
> tools/perf/bench/uprobe.c | 27 ++++++++++++++++++++++++---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/bench/uprobe.c b/tools/perf/bench/uprobe.c
> index 707174220a76701f..60e7c43298d8cf56 100644
> --- a/tools/perf/bench/uprobe.c
> +++ b/tools/perf/bench/uprobe.c
> @@ -34,6 +34,29 @@ static const char * const bench_uprobe_usage[] = {
> NULL
> };
>
> +static int bench_uprobe_format__default_fprintf(const char *name, const char *unit, u64 diff, FILE *fp)
> +{
> + static u64 baseline;
> + s64 diff_to_baseline = diff - baseline;
> + int printed = fprintf(fp, "# Executed %'d %s calls\n", loops, name);
> +
> + printed += fprintf(fp, " %14s: %'" PRIu64 " %ss", "Total time", diff, unit);
> +
> + if (baseline)
> + printed += fprintf(fp, " %s%'" PRId64 " to baseline", diff_to_baseline > 0 ? "+" : "", diff_to_baseline);
> +
> + printed += fprintf(fp, "\n\n %'.3f %ss/op", (double)diff / (double)loops, unit);
Just a nit, do we need to repeat (double) cast on the denominator side too?
> +
> + if (baseline)
> + printed += fprintf(fp, " %'.3f %ss/op to baseline", (double)diff_to_baseline / (double)loops, unit);
> + else
> + baseline = diff;
> +
> + fputc('\n', fp);
> +
> + return printed + 1;
> +}
> +
> static int bench_uprobe(int argc, const char **argv)
> {
> const char *name = "usleep(1000)", *unit = "usec";
> @@ -56,9 +79,7 @@ static int bench_uprobe(int argc, const char **argv)
>
> switch (bench_format) {
> case BENCH_FORMAT_DEFAULT:
> - printf("# Executed %'d %s calls\n", loops, name);
> - printf(" %14s: %'" PRIu64 " %ss\n\n", "Total time", diff, unit);
> - printf(" %'.3f %ss/op\n", (double)diff / (double)loops, unit);
> + bench_uprobe_format__default_fprintf(name, unit, diff, stdout);
> break;
>
> case BENCH_FORMAT_SIMPLE:
> --
> 2.41.0
>
--
Masami Hiramatsu (Google) <mhiramat@...nel.org>
Powered by blists - more mailing lists