[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <2067e0ec-0c5c-4f0f-6b1e-c084a3e433f4@linaro.org>
Date: Sat, 22 Jul 2023 11:23:08 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Duje Mihanović <duje.mihanovic@...le.hr>,
Michael Turquette <mturquette@...libre.com>,
Stephen Boyd <sboyd@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
afaerber@...e.com
Subject: Re: [PATCH 06/10] dt-bindings: clock: Add documentation for Marvell
PXA1908
On 21/07/2023 22:37, Duje Mihanović wrote:
> Add dt bindings and documentation for Marvell PXA1908's clock controller
> blocks.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> ---
> .../bindings/clock/marvell,pxa1908.yaml | 53 +++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml b/Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml
> new file mode 100644
> index 000000000000..3fa6f00a26f7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/marvell,pxa1908.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/marvell,pxa1908.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Marvell PXA1908 Clock Controllers
> +
> +maintainers:
> + - Duje Mihanović <duje.mihanovic@...le.hr>
> +
> +description: |
> + The PXA1908 clock subsystem generates and supplies clock to various
> + controllers within the PXA1908 SoC. The PXA1908 contains numerous clock
> + controller blocks, with the ones currently supported being APBC, APBCP, MPMU
> + and APMU roughly corresponding to internal buses.
> +
> + Each clock is assigned an identifier and client nodes use this identifier to
> + specify the clock which they consume.
Drop this sentence, it's obvious.
> +
> + All these identifiers could be found in <include/dt-bindings/marvell,pxa1908.h>.
"Clock identifiers ..."
> +
> +properties:
> + compatible:
> + enum:
> + - marvell,pxa1908-apbc
> + - marvell,pxa1908-apbcp
> + - marvell,pxa1908-mpmu
> + - marvell,pxa1908-apmu
Blank line
> + reg:
> + maxItems: 1
> + description: |
> + Physical address of the clock controller and length of the memory mapped
> + region.
Drop description, it is obvious.
> +
> + '#clock-cells':
> + const: 1
Best regards,
Krzysztof
Powered by blists - more mailing lists