linux-kernel - Re: [PATCH] dt-bindings: i2c: arb-gpio-challange: convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3e3b35a-e399-6739-1b01-e6f701af965c@linaro.org>
Date:   Sat, 22 Jul 2023 11:47:53 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     Peter Rosin <peda@...ntia.se>, Andi Shyti <andi.shyti@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, linux-i2c@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: i2c: arb-gpio-challange: convert to DT
 schema

On 21/07/2023 20:06, Doug Anderson wrote:
> Hi,
> 
> On Fri, Jul 21, 2023 at 6:30 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml
>> new file mode 100644
>> index 000000000000..17f15490f073
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/i2c/i2c-arb-gpio-challenge.yaml
>> @@ -0,0 +1,138 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/i2c/i2c-arb-gpio-challenge.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: GPIO-based I2C Arbitration Using a Challenge & Response Mechanism
>> +
>> +maintainers:
>> +  - Doug Anderson <dianders@...omium.org>
>> +  - Peter Rosin <peda@...ntia.se>
> 
> While I don't object to Peter Rosin being listed here if he wants it,
> I suspect that you added him because he was the author of
> "i2c-arb.txt". I guess that file was really only added to try to keep
> things common between this GPIO arbitrator and the one that he cares

I added him because he was listed as maintainer of all arbitration
bindings (as part of I2C MUX entry in MAINTAINERS).

> about: "nxp,pca9541.txt". Probably he doesn't want to be added here.
> 
> Speaking of "nxp,pca9541.txt", it seems like you need to convert that
> before removing "i2c-arb.txt". It still refers to that file even after
> your patch, doesn't it?

Indeed, thanks. I will convert it.

> 
> In any case, other than that, this looks fine. Thanks for doing the conversion!
> 
> Acked-by: Douglas Anderson <dianders@...omium.org>


Best regards,
Krzysztof