linux-kernel - Re: [PATCH v2 2/2] dt-bindings: ti-serdes-mux: Deprecate header with constants

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1a68e10-6530-d0d1-663f-61b3b01e8834@axentia.se>
Date:   Sat, 22 Jul 2023 12:18:50 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Jayesh Choudhary <j-choudhary@...com>, nm@...com, vigneshr@...com,
        kristo@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        rogerq@...nel.org
Cc:     s-vadapalli@...com, linux-arm-kernel@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: ti-serdes-mux: Deprecate header with
 constants

Hi!

2023-07-21 at 14:57, Jayesh Choudhary wrote:
> The constants to define the idle state of SERDES MUX were defined in
> bindings header. They are used only in DTS and driver uses the dt property
> to set the idle state making it unsuitable for bindings.
> The constants are moved to header next to DTS ("arch/arm64/boot/dts/ti/")
> and all the references to bindings header are removed.
> So add a warning to mark this bindings header as deprecated.
> 
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Acked-by: Roger Quadros <rogerq@...nel.org>

Best to keep this patch together with 1/2, so I'm assuming they will
take the same path to Linus, and that an ack from me will suffice.
Thanks again!

Acked-by: Peter Rosin <peda@...ntia.se>

Cheers,
Peter

> ---
>  include/dt-bindings/mux/ti-serdes.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/include/dt-bindings/mux/ti-serdes.h b/include/dt-bindings/mux/ti-serdes.h
> index 669ca2d6abce..b0b1091aad6d 100644
> --- a/include/dt-bindings/mux/ti-serdes.h
> +++ b/include/dt-bindings/mux/ti-serdes.h
> @@ -6,6 +6,14 @@
>  #ifndef _DT_BINDINGS_MUX_TI_SERDES
>  #define _DT_BINDINGS_MUX_TI_SERDES
>  
> +/*
> + * These bindings are deprecated, because they do not match the actual
> + * concept of bindings but rather contain pure constants values used only
> + * in DTS board files.
> + * Instead include the header in the DTS source directory.
> + */
> +#warning "These bindings are deprecated. Instead, use the header in the DTS source directory."
> +
>  /* J721E */
>  
>  #define J721E_SERDES0_LANE0_QSGMII_LANE1	0x0