linux-kernel - RE: [PATCH] mei: pxp: Keep a const qualifier when calling mei_cldev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MN2PR11MB4093A613B1EE0F1B4611B439E53CA@MN2PR11MB4093.namprd11.prod.outlook.com>
Date:   Sat, 22 Jul 2023 11:36:37 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] mei: pxp: Keep a const qualifier when calling
 mei_cldev_send()

> The API has been fixed in commit 0912ef4855e8 ("mei: constify passed
> buffers and structures"), so there is no more need to drop the const qualifier
> and the comment can be removed as-well.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Acked-by Tomas Winkler <tomas.winkler@...el.com>

> ---
>  drivers/misc/mei/pxp/mei_pxp.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/misc/mei/pxp/mei_pxp.c
> b/drivers/misc/mei/pxp/mei_pxp.c index 3bf560bbdee0..2dcb9169e404
> 100644
> --- a/drivers/misc/mei/pxp/mei_pxp.c
> +++ b/drivers/misc/mei/pxp/mei_pxp.c
> @@ -40,8 +40,7 @@ mei_pxp_send_message(struct device *dev, const void
> *message, size_t size)
> 
>  	cldev = to_mei_cl_device(dev);
> 
> -	/* temporary drop const qualifier till the API is fixed */
> -	byte = mei_cldev_send(cldev, (u8 *)message, size);
> +	byte = mei_cldev_send(cldev, message, size);
>  	if (byte < 0) {
>  		dev_dbg(dev, "mei_cldev_send failed. %zd\n", byte);
>  		return byte;
> --
> 2.34.1