linux-kernel - Re: [PATCH net-next v2 6/6] net: dsa: microchip: ksz9477: make switch MAC address configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95007aa6-a09b-4a05-93cb-65db405a2549@lunn.ch>
Date:   Sat, 22 Jul 2023 13:52:41 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Tristram.Ha@...rochip.com
Cc:     o.rempel@...gutronix.de, kernel@...gutronix.de,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        UNGLinuxDriver@...rochip.com, Woojung.Huh@...rochip.com,
        linux@...linux.org.uk, devicetree@...r.kernel.org,
        pabeni@...hat.com, kuba@...nel.org, davem@...emloft.net,
        Arun.Ramadoss@...rochip.com, edumazet@...gle.com,
        f.fainelli@...il.com, conor+dt@...nel.org, olteanv@...il.com,
        krzysztof.kozlowski+dt@...aro.org, robh+dt@...nel.org
Subject: Re: [PATCH net-next v2 6/6] net: dsa: microchip: ksz9477: make
 switch MAC address configurable

> The DSA driver used to have an API to set the MAC address to the switch,
> but it was removed because nobody used it.

That is a long time ago, when Marvell was about the only supported
vendor. As far as i understood, it was used to set the MAC source
address used when sending pause frames. But since pause frames are
link local by definition, and the switches had a reasonable default,
it was removed.

    Andrew