[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230722-occupant-outflank-bf433bc728c5@spud>
Date: Sat, 22 Jul 2023 12:57:55 +0100
From: Conor Dooley <conor@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: maxim,max8998: Convert to DT schema
On Fri, Jul 21, 2023 at 06:17:12PM +0200, Krzysztof Kozlowski wrote:
> Convert the bindings for Maxim MAX8998, National/TI LP3974 Power
> Management IC to DT schema. Adjust example to real DTS and make second
> interrupt optional (like on s5pv210-aries.dtsi).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../devicetree/bindings/mfd/max8998.txt | 125 -------
> .../bindings/mfd/maxim,max8998.yaml | 324 ++++++++++++++++++
> 2 files changed, 324 insertions(+), 125 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/max8998.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml b/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> new file mode 100644
> index 000000000000..f3c3f64fd012
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> @@ -0,0 +1,324 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/maxim,max8998.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX8998, National/TI LP3974 Power Management IC
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@...nel.org>
> +
> +description:
> + The Maxim MAX8998 is a Power Management IC which includes voltage/current
> + regulators, real time clock, battery charging controller and several other
> + sub-blocks. It is interfaced using an I2C interface. Each sub-block is
> + addressed by the host system using different i2c slave address.
> +
> +properties:
> + compatible:
> + enum:
> + - maxim,max8998
> + - national,lp3974
> + - ti,lp3974
Should one of these be marked as deprecated?
> + regulators:
> + type: object
> + additionalProperties: false
> +
> + properties:
> + CHARGER:
> + type: object
> + $ref: /schemas/regulator/regulator.yaml#
> + unevaluatedProperties: false
> + description:
> + CHARGER is main battery charger current control, wrongly represented
> + as regulator.
> +
> + properties:
> + regulator-min-microamp:
> + minimum: 90000
> + maximum: 800000
> +
> + regulator-max-microamp:
> + minimum: 90000
> + maximum: 800000
Did you pull these from the datasheet, or from the dts/example?
> +
> + regulator-min-microvolt: false
> + regulator-max-microvolt: false
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists