linux-kernel - Re: [PATCH] dt-bindings: mfd: maxim,max8998: Convert to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230722-job-cod-0a501b80e778@spud>
Date:   Sat, 22 Jul 2023 13:43:41 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Lee Jones <lee@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mfd: maxim,max8998: Convert to DT schema

On Sat, Jul 22, 2023 at 02:25:20PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2023 13:57, Conor Dooley wrote:
> > On Fri, Jul 21, 2023 at 06:17:12PM +0200, Krzysztof Kozlowski wrote:
> >> Convert the bindings for Maxim MAX8998, National/TI LP3974 Power
> >> Management IC to DT schema.  Adjust example to real DTS and make second
> >> interrupt optional (like on s5pv210-aries.dtsi).
> >>
> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> ---
> >>  .../devicetree/bindings/mfd/max8998.txt       | 125 -------
> >>  .../bindings/mfd/maxim,max8998.yaml           | 324 ++++++++++++++++++
> >>  2 files changed, 324 insertions(+), 125 deletions(-)
> >>  delete mode 100644 Documentation/devicetree/bindings/mfd/max8998.txt
> >>  create mode 100644 Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> > 
> >> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml b/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> >> new file mode 100644
> >> index 000000000000..f3c3f64fd012
> >> --- /dev/null
> >> +++ b/Documentation/devicetree/bindings/mfd/maxim,max8998.yaml
> >> @@ -0,0 +1,324 @@
> >> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> >> +%YAML 1.2
> >> +---
> >> +$id: http://devicetree.org/schemas/mfd/maxim,max8998.yaml#
> >> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >> +
> >> +title: Maxim MAX8998, National/TI LP3974 Power Management IC
> >> +
> >> +maintainers:
> >> +  - Krzysztof Kozlowski <krzk@...nel.org>
> >> +
> >> +description:
> >> +  The Maxim MAX8998 is a Power Management IC which includes voltage/current
> >> +  regulators, real time clock, battery charging controller and several other
> >> +  sub-blocks. It is interfaced using an I2C interface. Each sub-block is
> >> +  addressed by the host system using different i2c slave address.
> >> +
> >> +properties:
> >> +  compatible:
> >> +    enum:
> >> +      - maxim,max8998
> >> +      - national,lp3974
> >> +      - ti,lp3974
> > 
> > Should one of these be marked as deprecated?
> 
> We could deprecate national, because it was acquired by TI. But the chip
> was actually made by National - the datasheet I found has a National
> brand in product brief page and only the title page was added by TI.

It's probably unimportant, given you say this is unlikely to be used in
new hardware, but it does seem odd to me to have two compatibles for the
same chip.

> >> +  regulators:
> >> +    type: object
> >> +    additionalProperties: false
> >> +
> >> +    properties:
> >> +      CHARGER:
> >> +        type: object
> >> +        $ref: /schemas/regulator/regulator.yaml#
> >> +        unevaluatedProperties: false
> >> +        description:
> >> +          CHARGER is main battery charger current control, wrongly represented
> >> +          as regulator.
> >> +
> >> +        properties:
> >> +          regulator-min-microamp:
> >> +            minimum: 90000
> >> +            maximum: 800000
> >> +
> >> +          regulator-max-microamp:
> >> +            minimum: 90000
> >> +            maximum: 800000
> > 
> > Did you pull these from the datasheet, or from the dts/example?
> 
> From the driver.

Ah, thanks. Was just curious really.
Other than the deprecated thing looking odd, this stuff seemed fine to
me.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> TBH, this is, very very old device used in very old boards which I don't
> care about. I just want DT schema to be happy, so I don't think the
> bindings should be really correct. It's not like anyone will make any
> device with it.

Hopefully they don't :)


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)