linux-kernel - Re: [PATCH -next] clk: sunxi-ng: Modify mismatched function name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a60c8c63-509e-682c-16be-1a381b09b1eb@infradead.org>
Date:   Sat, 22 Jul 2023 07:31:22 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Zhang Jianhua <chris.zjh@...wei.com>, mturquette@...libre.com,
        sboyd@...nel.org, wens@...e.org, jernej.skrabec@...il.com,
        samuel@...lland.org, ulf.hansson@...aro.org, mripard@...nel.org
Cc:     linux-clk@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] clk: sunxi-ng: Modify mismatched function name



On 7/22/23 08:31, Zhang Jianhua wrote:
> No functional modification involved.
> 
> drivers/clk/sunxi-ng/ccu_mmc_timing.c:54: warning: expecting prototype for sunxi_ccu_set_mmc_timing_mode(). Prototype was for sunxi_ccu_get_mmc_timing_mode() instead
> 
> Fixes: f6f64ed868d3 ("clk: sunxi-ng: Add interface to query or configure MMC timing modes.")
> Signed-off-by: Zhang Jianhua <chris.zjh@...wei.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>
Thanks.

> ---
>  drivers/clk/sunxi-ng/ccu_mmc_timing.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/sunxi-ng/ccu_mmc_timing.c b/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> index 23a8d44e2449..78919d7843be 100644
> --- a/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> +++ b/drivers/clk/sunxi-ng/ccu_mmc_timing.c
> @@ -43,7 +43,7 @@ int sunxi_ccu_set_mmc_timing_mode(struct clk *clk, bool new_mode)
>  EXPORT_SYMBOL_GPL(sunxi_ccu_set_mmc_timing_mode);
>  
>  /**
> - * sunxi_ccu_set_mmc_timing_mode: Get the current MMC clock timing mode
> + * sunxi_ccu_get_mmc_timing_mode: Get the current MMC clock timing mode
>   * @clk: clock to query
>   *
>   * Return: %0 if the clock is in old timing mode, > %0 if it is in

-- 
~Randy