linux-kernel - Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics support menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mszou7kz.fsf@minerva.mail-host-address-is-not-set>
Date:   Sat, 22 Jul 2023 02:13:16 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     linux-kernel@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Helge Deller <deller@....de>,
        Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
        Jeffrey Hugo <quic_jhugo@...cinc.com>,
        Nipun Gupta <nipun.gupta@....com>,
        Oded Gabbay <ogabbay@...nel.org>,
        Pieter Jansen van Vuuren <pieter.jansen-van-vuuren@....com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v6 1/4] video: Add auxiliary display drivers to Graphics
 support menu

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> writes:

Hello Miguel,

> On Sat, Jul 22, 2023 at 12:46 AM Javier Martinez Canillas
> <javierm@...hat.com> wrote:
>>
>> Javier Martinez Canillas <javierm@...hat.com> writes:
>>
>> [adding Miguel Ojeda who was not in the Cc list]
>>
>> Hello Miguel, could you please ack this patch so that I can take the whole
>> patch-set through the drm-misc tree?
>
> A note below...
>
>> > The drivers in this subsystem are for character-based LCD displays, which
>> > can fall into the same category of the DRM/KMS and fbdev drivers that are
>> > located under the "Graphics support" menu. Add auxdisplay there as well.
>
> Nit: this is not exactly true, e.g. ks0108/cfag12864b (which were the
> first in the subsystem) were not character-based but a very simple
> black-or-white 128x64 grid, so we should probably reword slightly
> this.
>

Oh, interesting. I wonder why that couldn't had been a fbdev driver then
using FB_VISUAL_MONO01? I'll reword then the commit message before apply
to the following instead:

"The drivers in this subsystem are for either character-based or monochrome
LCD controllers, which can fall into the same category of the DRM/KMS and
fbdev drivers, that are located under the "Graphics support" menu.

Add the auxdisplay drivers there as well to have all display drivers under
the same menu."

> In any case, if Helge thinks these may belong in the "Graphics
> support" menu, then I am fine with it:
>
>     Acked-by: Miguel Ojeda <ojeda@...nel.org>
>

Perfect, thanks!

> Thanks!
>
> Cheers,
> Miguel
>

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat