lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZLs7RGhlbdhbOUK7@gondor.apana.org.au>
Date:   Sat, 22 Jul 2023 14:13:24 +1200
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Martin Kaiser <martin@...ser.cx>
Cc:     aric.pzqi@...enic.com, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: hwrng: ingenic: simplify the code

On Mon, Jul 10, 2023 at 10:27:26PM +0200, Martin Kaiser wrote:
> Simplify the ingenic-trng driver a bit. Switch to devm_clk_get_enabled and
> devm_hwrng_register. Remove some unused code.
> 
> The changes were compile-tested only (I don't have this hardware).
> 
> Martin Kaiser (7):
>   hwrng: ingenic - enable compile testing
>   hwrng: ingenic - remove two unused defines
>   hwrng: ingenic - remove dead assignments
>   hwrng: ingenic - use devm_clk_get_enabled
>   hwrng: ingenic - use dev_err_probe in error paths
>   hwrng: ingenic - don't disable the rng in ingenic_trng_remove
>   hwrng: ingenic - switch to device managed registration
> 
>  drivers/char/hw_random/Kconfig        |  3 +-
>  drivers/char/hw_random/ingenic-trng.c | 57 ++++++---------------------
>  2 files changed, 12 insertions(+), 48 deletions(-)
> 
> -- 
> 2.30.2

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ