linux-kernel - Re: [PATCH] ARM: dts: imx: Set default tuning step for imx7d usdhc0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2023 21:16:01 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Xiaolei Wang <xiaolei.wang@...driver.com>,
        Bough Chen <haibo.chen@....com>
Cc:     robh+dt@...nel.org, conor+dt@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, linux-imx@....com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx: Set default tuning step for imx7d usdhc0

Hi Xiaolei,

On Fri, Jul 21, 2023 at 8:21 PM Xiaolei Wang <xiaolei.wang@...driver.com> wrote:
>
> If the tuning step is not set, the tuning step is set to 1.
> For some sd cards, the following Tuning timeout will occur,
> so set the default tuning step.
>
> Tuning failed, falling back to fixed sampling clock
> mmc0: Tuning failed, falling back to fixed sampling clock
>
> Fixes: 1e336aa0c025 ("mmc: sdhci-esdhc-imx: correct the tuning start tap and step setting")
> Signed-off-by: Xiaolei Wang <xiaolei.wang@...driver.com>
> ---
>  arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
> index 75f1cd14bea1..d7396fbfcaf8 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts
> @@ -493,6 +493,7 @@ &usdhc1 {
>         vmmc-supply = <&reg_sd1_vmmc>;
>         wakeup-source;
>         keep-power-in-suspend;
> +       fsl,tuning-step = <2>;

I wondering if this should be a imx7s.dtsi property instead.

NXP vendor kernel passes:

fsl,tuning-step = <2>;
fsl,tuning-start-tap = <20>;

https://github.com/nxp-imx/linux-imx/blob/lf-6.1.y/arch/arm/boot/dts/imx7s.dtsi#L1216-L1217

Bough? Any suggestions?

Thanks